Code Review for DXpress

The Upload script
The Processing subroutine
The StyleSheet Class definition

This is my first excursion into Object Oriented programming, so definitely needs some reviewing.

The dx_upload.cgi uses CGI.pm, hence its extension. It is invoked from the page and throws up a form, which it processes on POST. The input file is cleaned and stored in the input directory. The dx_process_file.pl is then called (should I be using an eval at line 139?)

It is dx_process_file.pl which uses the stylesheet class. This is where I have my main worries.

The parser is based on a simple technique, due to Bruce Hunter of SGML Systems Engineering.

We have a StyleSheet object, called $current_ss which is created, loaded with the values for the invoked stylesheet. When an inline tag is encountered, as a line is processed, a new style sheet is created, called $running_ss, containing a copy of $current_ss. As each attribute in the tag is processed the values in $running_ss are altered. When the end of the tag is encountered then $current_ss is compared with $running_ss and any differences cause tags to be printed in the output file.

Specific Problems

Document Dated: Tue Sep 1 14:49:26 1998
Modify this document
Previous Version